Polonel

private:
        uint64 getPlayerOID(String name){
                uint64 player_oid;
 
                try {
 
                if(0!=(player_oid=server->getZoneServer()->getPlayerManager()->getObjectID(name)))
                        return player_oid;
                
                return 0;
 
                } catch (Exception& e) {
                        return 0;
                }
 
 
        }

Isn't this the same as getObjectID()? why is this even needed?

8:53 pm

Polonel

More
SWGEMU-15
commented on review

This is OR? oh I fear cRush is gonna have a field day on this... :|

2:55 am

Polonel

More
3027
changed 1 file
trunk in swgemu SWGEMU-12

[fixed] null check

- -1
- +1
/core3/trunk/MMOCoreORB/src/server/zone/managers/vendor/VendorSelectionNode.h
- History
- Source
- Diff
/core3/trunk/.../vendor/VendorSelectionNode.h

2:45 am

Polonel

More
3026
changed 86 files
trunk in swgemu SWGEMU-12

[updated] Vendors Update 2…

[updated] Vendors Update 2

[added] Initial Vendor Clothing

[added] Give Cothing to NPC Vendors

[added] Merchant XP

[fixed] Various vendor bug fixes

- -0
- +24
/core3/trunk/MMOCoreORB/bin/scripts/mobile/wearables/outfits.lua
- History
- Source
/core3/trunk/MMOCoreORB/.../wearables/outfits.lua
- -0
- +17
/core3/trunk/MMOCoreORB/src/server/zone/objects/tangible/terminal/vendor/VendorTerminalImplementation.cpp
- History
- Source
- Diff
/core3/.../VendorTerminalImplementation.cpp
- -0
- +105
/core3/trunk/MMOCoreORB/src/server/zone/managers/vendor/VendorOutfitManager.h
- History
- Source
/core3/trunk/.../vendor/VendorOutfitManager.h
- -1
- +1
/core3/trunk/MMOCoreORB/src/server/zone/objects/player/sessions/ImageDesignData.h
- History
- Source
- Diff
/core3/trunk/.../sessions/ImageDesignData.h
- -26
- +246
/core3/trunk/MMOCoreORB/bin/scripts/object/mobile/vendor/rodian_female.lua
- History
- Source
- Diff
/core3/trunk/.../vendor/rodian_female.lua
- -26
- +245
/core3/trunk/MMOCoreORB/bin/scripts/object/mobile/vendor/aqualish_female.lua
- History
- Source
- Diff
/core3/trunk/.../vendor/aqualish_female.lua
- -3
- +65
/core3/trunk/MMOCoreORB/src/server/zone/managers/vendor/VendorManager.h
- History
- Source
- Diff
/core3/trunk/.../vendor/VendorManager.h
- -26
- +239
/core3/trunk/MMOCoreORB/bin/scripts/object/mobile/vendor/aqualish_male.lua
- History
- Source
- Diff
/core3/trunk/.../vendor/aqualish_male.lua
- -26
- +241
/core3/trunk/MMOCoreORB/bin/scripts/object/mobile/vendor/twilek_female.lua
- History
- Source
- Diff
/core3/trunk/.../vendor/twilek_female.lua
- -1
- +1
/core3/trunk/MMOCoreORB/src/server/zone/managers/vendor/VendorSelectionNode.h
- History
- Source
- Diff
/core3/trunk/.../vendor/VendorSelectionNode.h
- -26
- +241
/core3/trunk/MMOCoreORB/bin/scripts/object/mobile/vendor/twilek_male.lua
- History
- Source
- Diff
/core3/trunk/.../vendor/twilek_male.lua
- -26
- +252
/core3/trunk/MMOCoreORB/bin/scripts/object/mobile/vendor/human_male.lua
- History
- Source
- Diff
/core3/trunk/.../vendor/human_male.lua
- -0
- +22
/core3/trunk/MMOCoreORB/src/server/zone/objects/player/sessions/vendor/CreateVendorSessionImplementation.cpp
- History
- Source
- Diff
/core3/.../CreateVendorSessionImplementation.cpp
- -0
- +98
/core3/trunk/MMOCoreORB/bin/scripts/mobile/wearables/humanoid_female_outfits.lua
- History
- Source
/core3/trunk/.../humanoid_female_outfits.lua
- -26
- +239
/core3/trunk/MMOCoreORB/bin/scripts/object/mobile/vendor/moncal_female.lua
- History
- Source
- Diff
/core3/trunk/.../vendor/moncal_female.lua
… 71 more files in changeset.

9:00 pm

Polonel

More
Re: SWGEMU-9
commented on review

Now if i can just make a tool to export these scripts for me, that will save a ton of time.

5:11 am

I like the splitting of the races into subscripts. I think it will make it easy to add Outfits to certain NPCs without having to search through a 1000 line file. I have tested this and it works wel...

I like the splitting of the races into subscripts. I think it will make it easy to add Outfits to certain NPCs without having to search through a 1000 line file. I have tested this and it works well

4:42 am

Polonel

More
Re: SWGEMU-9
commented on review

clothingCRC.add(shirtTemplate.hashCode()); clothingCRC.add(pantsTemplate.hashCode()); clothingCRC.add(shoesTemplate.hashCode()); I have added if st...

                clothingCRC.add(shirtTemplate.hashCode());
                clothingCRC.add(pantsTemplate.hashCode());
                clothingCRC.add(shoesTemplate.hashCode());

I have added if statements here to make sure the template path is not empty before adding them to the vector.

3:34 am

Polonel

More
Re: SWGEMU-9
commented on review

info(childOutfit->getOutfitName()); Only in for testing...

                info(childOutfit->getOutfitName());

Only in for testing...

3:33 am

Polonel

More
Re: SWGEMU-9
commented on review

if (idx < 0 || idx > outfits.size()) return NULL; should this be idx > outfits.size() -1 please clarify.

                if (idx < 0 || idx > outfits.size())
                        return NULL;

should this be idx > outfits.size() -1
please clarify.

3:32 am

Polonel

More
Re: SWGEMU-9
commented on review

I will prolly do away with these vars. As i added them before I made the vector and don't see a need for them since im storing the CRC of the template in the vector. What do you suggest?

3:30 am

Polonel

More
Re: SWGEMU-9
commented on review

I had planned on adding a template for each possible clothing item. If you think this is a feezable thing to do I'll do it. (ex. Jacket, Gloves, Helmet, etc) and just have them be blank if they are...

I had planned on adding a template for each possible clothing item. If you think this is a feezable thing to do I'll do it. (ex. Jacket, Gloves, Helmet, etc) and just have them be blank if they aren't part of the 'outfit' but that will give room for easy expansion just by adding the path to the lua.

3:28 am

Polonel

More
Re: SWGEMU-9
commented on review

Please give suggestion to the name / location of the manager. I was unsure so I went with OutfitterManager. If it can go on an existing manger please let me know which one would be best and I'll co...

Please give suggestion to the name / location of the manager. I was unsure so I went with OutfitterManager. If it can go on an existing manger please let me know which one would be best and I'll convert it over. I mainly want to make sure I have the outfit.h setup correctly and that im adding the clothes correctly to the VendorCreatures.

3:25 am