Moncai

About
  • First commit 03 August 2011
  • Latest commit 17 August 2011
Last Week All Time
Commits: 0 2
Files changed: 0 3
Change in LOC: 0 347

Reviews

3 active reviews

Counts may include data that you cannot access.

Line History

Line Count Graph
Line Count Graph
 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Moncai is mapped to 1 committer over 1 repository
Username Moncai is mapped to:
Wednesday 17 Aug 2011
2:13 pm

Moncai

[fixed] Radial menu for players cleaned up at back end.…
[fixed] Radial menu for players cleaned up at back end.

[changed] Option "Teach" now using new code path (work in progress).

Options
    • -32
    • +65
    /core3/trunk/MMOCoreORB/src/server/zone/objects/player/components/PlayerObjectMenuComponent.cpp
Wednesday 03 Aug 2011
4:12 pm

Moncai

Implementation of TipCommand
Implementation of TipCommand
Options
    • -0
    • +87
    /core3/trunk/MMOCoreORB/src/server/zone/objects/player/sui/callbacks/TipCommandSuiCallback.h
    • -40
    • +205
    /core3/trunk/MMOCoreORB/src/server/zone/objects/creature/commands/TipCommand.h
Wednesday 27 Jul 2011
4:38 pm

Moncai

Oops, missed that one.

Oops, missed that one.

2:00 pm

Moncai

I've tested this on Core3 [3202], when I get a tip it automatically updates in my inventory window instantly when I have it open regardless of the notifyClient parameter (which is ignored in Creatu...

I've tested this on Core3 [3202], when I get a tip it automatically updates in my inventory window instantly when I have it open regardless of the notifyClient parameter (which is ignored in CreatureObject.idl anyway). So, maybe this parameter is not necessary at all.

7:57 am

Moncai

Error with ManagedReference<A*> to A*&
Error with ManagedReference<A*> to A*&
7:07 am

Moncai

Will do

Will do

7:07 am

Moncai

That would be lovely, but this isn't in yet, is it?

That would be lovely, but this isn't in yet, is it?

7:06 am

Moncai

Indeed, I have grouped all the argument getting into the try-catch already in the new version.

Indeed, I have grouped all the argument getting into the try-catch already in the new version.

Tuesday 26 Jul 2011
3:37 pm

Moncai

I'll change this to PlayerObject* ghost = (PlayerObject*) player->getPlayerObject(); like you suggested for isPlayerCreature.

I'll change this to
PlayerObject* ghost = (PlayerObject*) player->getPlayerObject();
like you suggested for isPlayerCreature.

3:33 pm

Moncai

I'm adding a bool syntaxError http://www.swgemu.com/fisheye/static/mhd9mz/2static/images/wiki/icons/emoticons/smile.gif

I'm adding a bool syntaxError

3:26 pm

Moncai

I need to send the reference because this function sets it on line 77 or 98.

I need to send the reference because this function sets it on line 77 or 98.

3:22 pm

Moncai

This should not post a system message for the user, but an update package to the client would work. Also, this parameter isn't available with the subtract* methods, therefore I am unsure of it's in...

This should not post a system message for the user, but an update package to the client would work. Also, this parameter isn't available with the subtract* methods, therefore I am unsure of it's intended purpose.

3:08 pm

Moncai

I may or may not have to parse another token depending on the argument I got.

I may or may not have to parse another token depending on the argument I got.

2:12 pm

Moncai

Yes, absolutely right. Code duplication is bad.

Yes, absolutely right. Code duplication is bad.

1:54 pm

Moncai

if (isbank) doesn't need to perform the range check and the offline check and checks the bank balance instead of the cash balance?

if (isbank) doesn't need to perform the range check and the offline check and checks the bank balance instead of the cash balance?

1:53 pm

Moncai

The 5% surcharge is documented. The minimum of 1c isn't. I made this up to prevent spamming small tips of less than 20 credits which would circumvent the surcharge but tax the servers a lot.

The 5% surcharge is documented. The minimum of 1c isn't. I made this up to prevent spamming small tips of less than 20 credits which would circumvent the surcharge but tax the servers a lot.

1:45 pm

Moncai

I don't see why, as this command does something completely different (that is, setting up a callback to the client).

I don't see why, as this command does something completely different (that is, setting up a callback to the client).

Thursday 21 Jul 2011
4:43 pm

Moncai

  • More
  • SWGEMU-79
  • submitted for moderator approval
4:30 pm

Moncai

TipCommand.h [3202] refactor
TipCommand.h [3202] refactor