Moncai

[fixed] Radial menu for players cleaned up at back end.…
[fixed] Radial menu for players cleaned up at back end.

[changed] Option "Teach" now using new code path (work in progress).

Implementation of TipCommand
Implementation of TipCommand
Oops, missed that one.

Oops, missed that one.

I've tested this on Core3 [3202], when I get a tip it automatically updates in my inventory window instantly when I have it open regardless of the notifyClient parameter (which is ignored in Creatu...

I've tested this on Core3 [3202], when I get a tip it automatically updates in my inventory window instantly when I have it open regardless of the notifyClient parameter (which is ignored in CreatureObject.idl anyway). So, maybe this parameter is not necessary at all.

Error with ManagedReference<A*> to A*&
Error with ManagedReference<A*> to A*&
Will do

Will do

That would be lovely, but this isn't in yet, is it?

That would be lovely, but this isn't in yet, is it?

Indeed, I have grouped all the argument getting into the try-catch already in the new version.

Indeed, I have grouped all the argument getting into the try-catch already in the new version.

I'll change this to PlayerObject* ghost = (PlayerObject*) player->getPlayerObject(); like you suggested for isPlayerCreature.

I'll change this to
PlayerObject* ghost = (PlayerObject*) player->getPlayerObject();
like you suggested for isPlayerCreature.

I'm adding a bool syntaxError http://www.swgemu.com/fisheye/static/mhd9mz/2static/images/wiki/icons/emoticons/smile.gif

I'm adding a bool syntaxError

I need to send the reference because this function sets it on line 77 or 98.

I need to send the reference because this function sets it on line 77 or 98.

This should not post a system message for the user, but an update package to the client would work. Also, this parameter isn't available with the subtract* methods, therefore I am unsure of it's in...

This should not post a system message for the user, but an update package to the client would work. Also, this parameter isn't available with the subtract* methods, therefore I am unsure of it's intended purpose.

I may or may not have to parse another token depending on the argument I got.

I may or may not have to parse another token depending on the argument I got.

Yes, absolutely right. Code duplication is bad.

Yes, absolutely right. Code duplication is bad.

if (isbank) doesn't need to perform the range check and the offline check and checks the bank balance instead of the cash balance?

if (isbank) doesn't need to perform the range check and the offline check and checks the bank balance instead of the cash balance?

The 5% surcharge is documented. The minimum of 1c isn't. I made this up to prevent spamming small tips of less than 20 credits which would circumvent the surcharge but tax the servers a lot.

The 5% surcharge is documented. The minimum of 1c isn't. I made this up to prevent spamming small tips of less than 20 credits which would circumvent the surcharge but tax the servers a lot.

I don't see why, as this command does something completely different (that is, setting up a callback to the client).

I don't see why, as this command does something completely different (that is, setting up a callback to the client).

  • More
  • SWGEMU-79
  • submitted for moderator approval
TipCommand.h [3202] refactor
TipCommand.h [3202] refactor