Cebot

Did you have any other questions about this?

Did you have any other questions about this?

No, because p = the coordinate of the PlanetTravelPoint that was created by the placement of the shuttleport, so the Z of that coordinate is consistent with the shuttleport's actual height.

No, because p = the coordinate of the PlanetTravelPoint that was created by the placement of the shuttleport, so the Z of that coordinate is consistent with the shuttleport's actual height.

Thanks to ElPete for the help figuring out how to interpret the shuttle direction.

Thanks to ElPete for the help figuring out how to interpret the shuttle direction.

  • More
  • SWGEMU-517
  • submitted for moderator approval
  • More
  • SWGEMU-507
  • submitted for moderator approval
Ok, figured it out. Added another patch that shows those.

Ok, figured it out. Added another patch that shows those.

Sorry for my noobishness with SVN, but how do I remove files? If I remove them from my local copy and generate a new patch, will it include that kind of change?

Sorry for my noobishness with SVN, but how do I remove files? If I remove them from my local copy and generate a new patch, will it include that kind of change?

And in retrospect, I should also have changed the existing check to >=, rather than ==, just in case some weird condition happens that would have allowed a 21st person, and therefore 22, 23, etc.

And in retrospect, I should also have changed the existing check to >=, rather than ==, just in case some weird condition happens that would have allowed a 21st person, and therefore 22, 23, etc.

Crap. Yes - wasn't going to try getting 20 chars online on one client machine http://www.swgemu.com/fisheye/static/mhd9mz/2static/images/wiki/icons/emoticons/smile.gif Though it strikes me as bad ...

Crap. Yes - wasn't going to try getting 20 chars online on one client machine

Though it strikes me as bad practice to have had this hard-coded in the first place, rather than as a config parameter (or a constant at the very least).

  • More
  • SWGEMU-462
  • submitted for moderator approval
  • More
  • SWGEMU-449
  • submitted for moderator approval
  • More
  • SWGEMU-446
  • submitted for moderator approval
Damn. I hate it when I'm wrong. http://www.swgemu.com/fisheye/static/mhd9mz/2static/images/wiki/icons/emoticons/smile.gif /deepbow I was mis-interpreting that as the number per rank, obviously.

Damn. I hate it when I'm wrong. /deepbow

I was mis-interpreting that as the number per rank, obviously.

My original patch has been tested, and while yours is slightly more efficient (breaks out of the loop as soon as totalAtRank > maxAtRank), it's also flawed because it compares city >= rank, not cit...

My original patch has been tested, and while yours is slightly more efficient (breaks out of the loop as soon as totalAtRank > maxAtRank), it's also flawed because it compares city >= rank, not city == rank. The list of rank caps is per rank, and cities of a higher rank are irrelevant.

After much discussion about this tonight, I'm also thinking the check for totalCities > maxCities (the number of outposts, really) should go away. Just because the planet somehow got over the limit...

After much discussion about this tonight, I'm also thinking the check for totalCities > maxCities (the number of outposts, really) should go away. Just because the planet somehow got over the limit doesn't mean no one should be able to progress.I updated the patch to reflect this change.

Just other community members - nothing official. But it doesn't make sense to stop an entire planet's worth of city progression just because there are too many cities total.

Just other community members - nothing official. But it doesn't make sense to stop an entire planet's worth of city progression just because there are too many cities total.

The basic issue with city advancement is that the "isCityRankCapped" was returning "true" too often because it wasn't comparing the cities by rank, just the total count. This one is "the sooner the...

The basic issue with city advancement is that the "isCityRankCapped" was returning "true" too often because it wasn't comparing the cities by rank, just the total count. This one is "the sooner the better" because the longer we wait to fix it, the more cities get stuck, and it won't untangle itself very well.

  • More
  • SWGEMU-375
  • submitted for moderator approval