SWGEMU-742 [Added] Tekil Barje's quests in Wayfar, Tatooine

Details
Objectives
General Comments 1 (0)

tekil_barje_task2.patch (2 months and 24 days ago) 0 (0)
- workspace/MMOCoreORB/bin/scripts 0 (0)
  - loot 0 (0)
    - groups 0 (0)
      - task_reward_tekil_barje_1.lua 0 (0) x
      - task_reward_tekil_barje_2.lua 0 (0) x
      - task_reward_tekil_barje_3.lua 0 (0) x
    - groups.lua 0 (0) x
  - managers/spawn_manager 0 (0)
    - tatooine.lua 0 (0) x
  - mobile 0 (0)
    - conversations/themepark/rebel 0 (0)
      - mission_giver_conv.lua 0 (0) x
      - mission_target_conv.lua 0 (0) x
    - tatooine 0 (0)
      - digger_dimms.lua 0 (0) x
      - serverobjects.lua 0 (0) x
      - tekil_barje.lua 0 (0) x
  - screenplays 0 (0)
    - tasks 0 (0)
      - tekil_barje.lua 0 (0) x
    - screenplay.lua 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Ivojedi	Author	16m
TheAnswer	Moderator	0m
Itac	Reviewer - 0% complete
Loshult	Reviewer - 0% complete	0m	1	We have started to use Gerrit for reviews instead of Fish...
cRush	Reviewer - 0% complete
dannuic	Reviewer - 0% complete
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 0% complete
Total		16m	1

Files: 12
Patches:
- tekil_barje_task.patch: (anchored to : / )
- tekil_barje_task2.patch: (anchored to swgemu : core3/branches/unstable/ )

#permalink

Objectives

[Added] Tekil Barje's quests in Wayfar, Tatooine

I added the quests using the themepark logic. The quest is fully functional, though I had two observations of things that are not quite right.

First, Tekil Barje is naked. He appears to have the correct template and I've no idea how to correct his appearance. He's naked on Nova as well, so it's not a new thing introduced with this patch.

Second, there are three quests in this series, but the third does not have a breech string in the string files. Because of this, the tusken raiders in the last step, when attacked, say "static_npc/tatooine/tekil_barje:[npc_breech_3]".

The first patch had changes from a separate patch. The second is correct and current.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

17 Mar

Loshult says:

We have started to use Gerrit for reviews instead of Fishey. Please follow the instructions on the following page: https://www.assembla.com/spaces/swgemu/wiki/Git_Gerrit_and_Jenkins and push your patch to Gerrit instead.

#permalink

/workspace/.../groups/task_reward_tekil_barje_1.lua Added #permalink
Click to load diff

/workspace/.../groups/task_reward_tekil_barje_2.lua Added #permalink
Click to load diff

/workspace/.../groups/task_reward_tekil_barje_3.lua Added #permalink
Click to load diff

/workspace/MMOCoreORB/.../loot/groups.lua Changed #permalink
Click to load diff

/workspace/.../spawn_manager/tatooine.lua Changed #permalink
Click to load diff

/workspace/.../rebel/mission_giver_conv.lua Changed #permalink
Click to load diff

/workspace/.../rebel/mission_target_conv.lua Changed #permalink
Click to load diff

/workspace/.../tatooine/digger_dimms.lua Added #permalink
Click to load diff

/workspace/.../tatooine/serverobjects.lua Changed #permalink
Click to load diff

/workspace/.../tatooine/tekil_barje.lua Changed #permalink
Click to load diff

/workspace/.../tasks/tekil_barje.lua Added #permalink
Click to load diff

/workspace/.../screenplays/screenplay.lua Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-742

[Added] Tekil Barje's quests in Wayfar, Tatooine

Abandoned on 19 Mar

Author

Moderator

Reviewers

SWGEMU-742 1 (0)

Details

Objectives

Issues Raised From Comments

General Comments

Loshult says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-742

[Added] Tekil Barje's quests in Wayfar, Tatooine

Abandoned on 19 Mar

Author

Moderator

Reviewers

SWGEMU-742 1 (0)

Summarize the review outcomes (optional)

Details

Objectives

Issues Raised From Comments

General Comments

Loshult says:

Create Issue

Log time against