SWGEMU-652 Milking Implementation - Part 3 (final)

Details
Objectives
General Comments 1 (0)

milking_final2.patch (3 months and 8 days ago) 0 (0)
- workspace/MMOCoreORB/src/server/zone/objects/creature/events 0 (0)
  - MilkCreatureTask.h 3 (0) x
milking_final3.patch (2 months and 27 days ago) 0 (0)
- workspace/MMOCoreORB/src/server/zone/objects/creature/events 0 (0)
  - MilkCreatureTask.h 3 (0) x
milking_final4.patch (2 months and 25 days ago) 0 (0)
- workspace/MMOCoreORB/src/server/zone 0 (0)
  - managers/creature 0 (0)
    - CreatureManager.cpp 0 (0) x
    - CreatureManager.h 0 (0) x
    - CreatureManager.idl 0 (0) x
    - CreatureManagerImplementation.cpp 0 (0) x
  - objects/creature 0 (0)
    - events 0 (0)
      - MilkCreatureTask.h 0 (0) x
    - Creature.cpp 0 (0) x
    - Creature.h 0 (0) x
    - Creature.idl 0 (0) x
    - CreatureImplementation.cpp 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Ivojedi	Author	43m	2	I created the function to do as you asked and call it eac...
TheAnswer	Moderator	0m
Itac	Reviewer - 0% complete
Loshult	Reviewer - 57% complete	34m	5	We have started to use Gerrit for reviews instead of Fish...
cRush	Reviewer - 0% complete
dannuic	Reviewer - 0% complete
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 0% complete
Total		1h 18m	7

Files: 11
Patches:
- milking_final.patch: (anchored to : / )
- milking_final2.patch: (anchored to swgemu : core3/branches/unstable/ )
- milking_final3.patch: (anchored to swgemu : core3/branches/unstable/ )
- milking_final4.patch: (anchored to swgemu : core3/branches/unstable/ )

#permalink

Objectives

[Added] The ability to milk creatures

I could not find any good info on the success vs. aggro chances while milking. I therefore came up with a formula that takes the creature's ferocity and the players maskscent/camo skill mods into account.

The way maskscent and conceal are implemented right now, they are both putting the same maskscent buff on the player so it was impossible to distinguish between them when checking the player's buffs. I therefore set the formula up to use both skill mods together. This may be extra generous to rangers right now, but the majority of milkable creatures are low ferocity anyway so regardless of skill, the aggro chance is going to be low. I intend to fix the formula once conceal is fixed to use it's own buff type.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

17 Mar

Loshult says:

We have started to use Gerrit for reviews instead of Fishey. Please follow the instructions on the following page: https://www.assembla.com/spaces/swgemu/wiki/Git_Gerrit_and_Jenkins and push your patch to Gerrit instead.

#permalink

/workspace/.../events/MilkCreatureTask.h Added 3 (0) #permalink
Click to load diff

/workspace/.../events/MilkCreatureTask.h Added 3 (0) #permalink
Click to load diff

/workspace/.../creature/CreatureManager.cpp Changed #permalink
Click to load diff

/workspace/.../creature/CreatureManager.h Changed #permalink
Click to load diff

/workspace/.../creature/CreatureManager.idl Changed #permalink
Click to load diff

/workspace/.../creature/CreatureManagerImplementation.cpp Changed #permalink
Click to load diff

/workspace/.../events/MilkCreatureTask.h Added #permalink
Click to load diff

/workspace/.../creature/Creature.cpp Changed #permalink
Click to load diff

/workspace/MMOCoreORB/.../creature/Creature.h Changed #permalink
Click to load diff

/workspace/.../creature/Creature.idl Changed #permalink
Click to load diff

/workspace/.../creature/CreatureImplementation.cpp Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-652

Milking Implementation - Part 3 (final)

Abandoned on 19 Mar

Author

Moderator

Reviewers

SWGEMU-652 7 (0)

Details

Objectives

Issues Raised From Comments

General Comments

Loshult says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-652

Milking Implementation - Part 3 (final)

Abandoned on 19 Mar

Author

Moderator

Reviewers

SWGEMU-652 7 (0)

Summarize the review outcomes (optional)

Details

Objectives

Issues Raised From Comments

General Comments

Loshult says:

Create Issue

Log time against