SWGEMU-542 Resist Buffs

Details
Objectives
Summary
General Comments 3 (0)

ResistBuffs.txt (3 months and 25 days ago) 0 (0)
- src/server/zone/objects/creature/damageovertime 0 (0)
  - DamageOverTimeList.cpp 5 (0) x
ResistBuffs-2.txt (3 months and 10 days ago) 0 (0)
- bin/scripts/object 0 (0)
  - draft_schematic/chemistry 0 (0)
    - medpack_enhance_disease_a.lua 0 (0) x
    - medpack_enhance_disease_b.lua 0 (0) x
    - medpack_enhance_disease_c.lua 0 (0) x
    - medpack_enhance_poison_a.lua 0 (0) x
    - medpack_enhance_poison_b.lua 0 (0) x
    - medpack_enhance_poison_c.lua 0 (0) x
  - tangible/medicine/crafted 0 (0)
    - medpack_enhance_disease_a.lua 0 (0) x
    - medpack_enhance_disease_b.lua 0 (0) x
    - medpack_enhance_disease_c.lua 0 (0) x
    - medpack_enhance_poison_a.lua 0 (0) x
    - medpack_enhance_poison_b.lua 0 (0) x
    - medpack_enhance_poison_c.lua 0 (0) x
- src/server/zone 0 (0)
  - managers/player 0 (0)
    - PlayerManagerImplementation.cpp 0 (0) x
  - objects/creature 0 (0)
    - commands 0 (0)
      - HealEnhanceCommand.h 0 (0) x
    - damageovertime 0 (0)
      - DamageOverTimeList.cpp 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Bert	Author	29m	4	Removed
TheAnswer	Moderator	1m
Itac	Reviewer - 0% complete
Loshult	Reviewer - 6% complete	16m	4	It seems to make two tries and if both fails then we do n...
cRush	Reviewer - 0% complete
dannuic	Reviewer - 0% complete
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 0% complete	0m
Total		46m	8

Files: 16
Patches:
- ResistBuffs.txt: (anchored to : / )
- ResistBuffs-2.txt: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )

#permalink

Objectives

[FIXED] Resist Buffs applying to character
[FIXED] Resist buffs using wound treatment modifier
[FIXED] Chance to apply dots to buffed and unbuffed targets
[FIXED] Overwriting buffs not giving the correct response
[FIXED] Resist pack values more in line with Pre-cu stats

#permalink

Summary

Patch committed to unstable branch.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

21 Jan

Bert says:

Research documentation:

-Resist pack values = http://web.archive.org/web/20050205185410/http://forums.station.sony.com/swg/board/message?board.id=doctor&message.id=80380
-Resist buffs not using wound treatment = http://web.archive.org/web/20050218124800/http://forums.station.sony.com/swg/board/message?board.id=combat_medic&message.id=39676
-Creating chance to apply dots equation = http://web.archive.org/web/20040914223306/http://forums.station.sony.com/swg/board/message?board.id=combat_medic&message.id=40604&view=by_date_ascending&page=1

The wayback machine ate that last post which had actual potency vs resist testing done (hope it works when you go to review). I based my math off of it which showed that when the potency and resist were near equal, it was around a 50/50 chance. Then when there was around a potency over 100 more than resist the chance was 90+% and when resist was 100 or more over potency, it resisted 90+%. Hopefully that page becomes viewable again so it doesn't look like I made up the numbers randomly.

As far as the resist packs themselves, the page shows components only contributing 50% of their values to final combine, and that the final combine numbers were 1/2 of what we have now.

#permalink

27 Jan

Loshult says:

Have you used the Crafting tool to generate these changes? Otherwise they will be overwritten in the next big update we do.

#permalink

30 Jan

Bert says:

I downloaded the tool, but I have not found a way to make the changes to the schematics that I have on here. I'm not sure if the tool has those options or not.

#permalink

/src/.../damageovertime/DamageOverTimeList.cpp Changed 5 (0) #permalink
Click to load diff

/bin/.../chemistry/medpack_enhance_disease_a.lua Changed #permalink
Click to load diff

/bin/.../chemistry/medpack_enhance_disease_b.lua Changed #permalink
Click to load diff

/bin/.../chemistry/medpack_enhance_disease_c.lua Changed #permalink
Click to load diff

/bin/.../chemistry/medpack_enhance_poison_a.lua Changed #permalink
Click to load diff

/bin/.../chemistry/medpack_enhance_poison_b.lua Changed #permalink
Click to load diff

/bin/.../chemistry/medpack_enhance_poison_c.lua Changed #permalink
Click to load diff

/bin/.../crafted/medpack_enhance_disease_a.lua Changed #permalink
Click to load diff

/bin/.../crafted/medpack_enhance_disease_b.lua Changed #permalink
Click to load diff

/bin/.../crafted/medpack_enhance_disease_c.lua Changed #permalink
Click to load diff

/bin/.../crafted/medpack_enhance_poison_a.lua Changed #permalink
Click to load diff

/bin/.../crafted/medpack_enhance_poison_b.lua Changed #permalink
Click to load diff

/bin/.../crafted/medpack_enhance_poison_c.lua Changed #permalink
Click to load diff

/src/.../player/PlayerManagerImplementation.cpp Changed #permalink
Click to load diff

/src/server/.../commands/HealEnhanceCommand.h Changed #permalink
Click to load diff

/src/.../damageovertime/DamageOverTimeList.cpp Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-542

Resist Buffs

Closed on 05 Feb

Author

Moderator

Reviewers

SWGEMU-542 8 (0)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Bert says:

Loshult says:

Bert says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-542

Resist Buffs

Closed on 05 Feb

Author

Moderator

Reviewers

SWGEMU-542 8 (0)

Summarize the review outcomes (optional)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Bert says:

Loshult says:

Bert says:

Create Issue

Log time against