SWGEMU-538 Fix costs of some actions to consider strength/quickness/focus - mantis 3630

Details
Objectives
Summary
General Comments 3 (0)

actions_costs2.patch (4 months ago) 0 (0)
- workspace/MMOCoreORB-Testing/src/server/zone 0 (0)
  - managers 0 (0)
    - minigames 0 (0)
      - ForageManagerImplementation.cpp 2 (0) x
    - resource/resourcespawner 0 (0)
      - ResourceSpawner.cpp 0 (0) x
  - objects 0 (0)
    - creature/commands 0 (0)
      - ThrowTrapCommand.h 0 (0) x
    - player/sessions 0 (0)
      - survey 0 (0)
        
        SurveySessionImplementation.cpp 0 (0) x
      - EntertainingSessionImplementation.cpp 0 (0) x
actions_costs3.patch (3 months and 22 days ago) 0 (0)
- workspace/MMOCoreORB-Testing/src/server/zone 0 (0)
  - managers 0 (0)
    - minigames 0 (0)
      - ForageManagerImplementation.cpp 0 (0) x
    - resource/resourcespawner 0 (0)
      - ResourceSpawner.cpp 0 (0) x
  - objects 0 (0)
    - creature 0 (0)
      - commands 0 (0)
        
        ColorlightsCommand.h 0 (0) x
        
        DazzleCommand.h 0 (0) x
        
        DistractCommand.h 0 (0) x
        
        FirejetCommand.h 0 (0) x
        
        SmokebombCommand.h 0 (0) x
        
        SpotlightCommand.h 0 (0) x
        
        ThrowTrapCommand.h 0 (0) x
        
        VentriloquismCommand.h 0 (0) x
      - CreatureObject.cpp 0 (0) x
      - CreatureObject.h 0 (0) x
      - CreatureObject.idl 0 (0) x
      - CreatureObjectImplementation.cpp 0 (0) x
    - player/sessions 0 (0)
      - survey 0 (0)
        
        SurveySessionImplementation.cpp 0 (0) x
      - EntertainingSessionImplementation.cpp 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Ivojedi	Author	58m	2	I've done as instructed and separated the calculation int...
TheAnswer	Moderator	4m	1	Instead of changing inflictDamaga, should just add a calc...
Itac	Reviewer - 0% complete
Loshult	Reviewer - 90% complete	29m	2	I think we should intoduce a new method and use instead o...
cRush	Reviewer - 0% complete
dannuic	Reviewer - 0% complete
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 4% complete	0m
Total		1h 32m	5

Files: 21
Patches:
- actions_costs.patch: (anchored to : / )
- actions_costs2.patch: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )
- actions_costs3.patch: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )

#permalink

Objectives

[Fixed] costs of many actions to properly take Strength, Quickness, and Focus into account - mantis 3630. The following actions are affected: dancing, playing music, flourishing, all the musician/dancer light effects, surveying, sampling, foraging, and throwing scout traps.

I couldn't find any good info on how the costs were calculated on live, but I think I came up with a reasonable formula that I used for all of the included changes. Any strength/quickness/focus over 300 will reduce the cost by a percentage equal to 5% of the magnitude of the stat over 300.

Eg. A 1300 quickness will reduce the cost to flourish by 50%, 2300 will reduce the cost to zero. A 300 quickness will use the base cost.

The Third patch is current.

#permalink

Summary

Patch committed to unstable branch.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

27 Jan

Loshult says:

I think we should intoduce a new method and use instead of inflictDamage that does this reduction based on the secondary HAM stats instead of spreading out this calculation all over the code (adding an argument to the inflictDamage method might work as well). That new method should also ensure that the player doesn't gain HAM when having the secondary stat over 2300 which very well could happen with strong buffs.

I want TheAnswer to have a look at this before you do anything though.

#permalink

27 Jan

TheAnswer says:

Instead of changing inflictDamaga, should just add a calculateReduction or similar to remove all the redundant code and make it reusable.

#permalink

28 Jan

Ivojedi says:

I've done as instructed and separated the calculation into it's own method within the CreatureObject class. I made sure to put a check in there to ensure that the cost never goes below zero. I also added this reduction to the other musician/dancer commands that I had forgotten the first time around. The third patch is complete with all of the changes.

#permalink

/workspace/.../minigames/ForageManagerImplementation.cpp Changed 2 (0) #permalink
Click to load diff

/workspace/.../resourcespawner/ResourceSpawner.cpp Changed #permalink
Click to load diff

/workspace/.../commands/ThrowTrapCommand.h Changed #permalink
Click to load diff

/workspace/.../survey/SurveySessionImplementation.cpp Changed #permalink
Click to load diff

/workspace/.../sessions/EntertainingSessionImplementation.cpp Changed #permalink
Click to load diff

/workspace/.../minigames/ForageManagerImplementation.cpp Changed #permalink
Click to load diff

/workspace/.../resourcespawner/ResourceSpawner.cpp Changed #permalink
Click to load diff

/workspace/.../commands/ColorlightsCommand.h Changed #permalink
Click to load diff

/workspace/.../commands/DazzleCommand.h Changed #permalink
Click to load diff

/workspace/.../commands/DistractCommand.h Changed #permalink
Click to load diff

/workspace/.../commands/FirejetCommand.h Changed #permalink
Click to load diff

/workspace/.../commands/SmokebombCommand.h Changed #permalink
Click to load diff

/workspace/.../commands/SpotlightCommand.h Changed #permalink
Click to load diff

/workspace/.../commands/ThrowTrapCommand.h Changed #permalink
Click to load diff

/workspace/.../commands/VentriloquismCommand.h Changed #permalink
Click to load diff

/workspace/.../creature/CreatureObject.cpp Changed #permalink
Click to load diff

/workspace/.../creature/CreatureObject.h Changed #permalink
Click to load diff

/workspace/.../creature/CreatureObject.idl Changed #permalink
Click to load diff

/workspace/.../creature/CreatureObjectImplementation.cpp Changed #permalink
Click to load diff

/workspace/.../survey/SurveySessionImplementation.cpp Changed #permalink
Click to load diff

/workspace/.../sessions/EntertainingSessionImplementation.cpp Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-538

Fix costs of some actions to consider strength/quickness/focus - mantis 3630

Closed on 05 Feb

Author

Moderator

Reviewers

SWGEMU-538 5 (0)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Loshult says:

TheAnswer says:

Ivojedi says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-538

Fix costs of some actions to consider strength/quickness/focus - mantis 3630

Closed on 05 Feb

Author

Moderator

Reviewers

SWGEMU-538 5 (0)

Summarize the review outcomes (optional)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Loshult says:

TheAnswer says:

Ivojedi says:

Create Issue

Log time against