SWGEMU-530 Vardias Tyne quest fix + cleanup

Details
Objectives
Summary
General Comments 5 (0)

review530-v2.txt (4 months and 3 days ago) 0 (0)
- bin/scripts/screenplays/tasks 0 (0)
  - vardias_tyne.lua 2 (0) x
review530-v6.txt (3 months and 10 days ago) 0 (0)
- bin/scripts 0 (0)
  - loot/groups 0 (0)
    - task_reward_vardias_tyne.lua 0 (0) x
  - mobile 0 (0)
    - conversations/tasks 0 (0)
      - vardias_tyne_conv.lua 0 (0) x
    - tatooine 0 (0)
      - Bantha_E3.lua 0 (0) x
      - Dim_U_bantha.lua 0 (0) x
      - bantha_e3.lua 0 (0) x
      - chonar.lua 0 (0) x
      - dim_u_bantha.lua 0 (0) x
      - rhalia_jinsari.lua 0 (0) x
      - serverobjects.lua 0 (0) x
      - vardias_tyne.lua 0 (0) x
    - conversations.lua 0 (0) x
  - screenplays/tasks 0 (0)
    - vardias_tyne.lua 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
bluree	Author	2h 32m	4	Done. -groups.lua were updated in rev 6405, same with mi...
TheAnswer	Moderator	0m
Itac	Reviewer - 0% complete
Loshult	Reviewer - 100% complete	13m	3	Please update this patch to head. I get conflicts when tr...
cRush	Reviewer - 0% complete
dannuic	Reviewer - 0% complete
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 0% complete	5m
Total		2h 50m	7

Files: 13
Patches:
- review530-v1.txt: (anchored to : / )
- review530-v2.txt: (anchored to : / )
- review530-v3.txt: (anchored to : / )
- review530-v4.txt: (anchored to : / )
- review530-v5.txt: (anchored to : / )
- review530-v6.txt: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )

#permalink

Objectives

[Fixed] Fixed and cleaned up Vardias Tyne quest.

Quest starts at 104, -5382 in AnchorHead, Tatooine.

***

-02/04 - review530-v5.txt
******

Renamed task reward.
Reorganized screenplays/task/quest.

-01/15 - review530-v3.txt
******

Added missing lootgroup.

-01/13 - review530-v2.txt
******

Quest fixed and converted to use themepark logic.

-01/12 - review530-v1.txt
******

Quest fixes submitted for review.

#permalink

Summary

Patch committed to unstable branch.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

13 Jan

bluree says:

updated review530-v2.

themeparklogic needs some tweaks, mainly proximity breech for quest that have npc_breech_1(2). currently you have to speak with the npc where as this is supposed to be proximity based convo's according to stf and preCU docs.

IE: when approaching a assassination mission/target you shouldnt have to speak with the npc for him to tell you he's going to kill you if you get closer.

@static_npc/tatooine/vardias_tyne:npc_breech_1 - Come between me and my mark and you will share their fate!

**

Edit: found something else. will chat you later

#permalink

15 Jan

Loshult says:

If you want you could try to modify the theme park logic for the proximity breech in a new patch.

#permalink

15 Jan

bluree says:

Will check it out later tonight.

Updated review to include missing lootgroup.

#permalink

05 Feb

Loshult says:

Please update this patch to head. I get conflicts when trying to apply it.

#permalink

06 Feb

bluree says:

Done.

-groups.lua were updated in rev 6405, same with mission_giver/target_conv.lua so they don't need to be added to this review again.

I did the reviews/quest in a certain order so I wouldn't have to keep updating to head after each one is commited even when you get conflicts they should still patch to your dev envir without issue(unless someone else modified a serverobjects in another review)

1st: review530
2nd: review563 - commited already
3rd: review564
4th: review565
—
reviews after 565 i just went back to normal format and those I will need to be updated to head once you get around to those.

#permalink

/bin/scripts/.../tasks/vardias_tyne.lua Changed 2 (0) #permalink
Click to load diff

/bin/.../groups/task_reward_vardias_tyne.lua Added #permalink
Click to load diff

/bin/scripts/.../tasks/vardias_tyne_conv.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/tatooine/Bantha_E3.lua Changed #permalink
Click to load diff

/bin/scripts/.../tatooine/Dim_U_bantha.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/tatooine/bantha_e3.lua Added #permalink
Click to load diff

/bin/scripts/mobile/tatooine/chonar.lua Added #permalink
Click to load diff

/bin/scripts/.../tatooine/dim_u_bantha.lua Added #permalink
Click to load diff

/bin/scripts/.../tatooine/rhalia_jinsari.lua Added #permalink
Click to load diff

/bin/scripts/.../tatooine/serverobjects.lua Changed #permalink
Click to load diff

/bin/scripts/.../tatooine/vardias_tyne.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/conversations.lua Changed #permalink
Click to load diff

/bin/scripts/.../tasks/vardias_tyne.lua Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-530

Vardias Tyne quest fix + cleanup

Closed on 06 Feb

Author

Moderator

Reviewers

SWGEMU-530 7 (0)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

bluree says:

Loshult says:

bluree says:

Loshult says:

bluree says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-530

Vardias Tyne quest fix + cleanup

Closed on 06 Feb

Author

Moderator

Reviewers

SWGEMU-530 7 (0)

Summarize the review outcomes (optional)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

bluree says:

Loshult says:

bluree says:

Loshult says:

bluree says:

Create Issue

Log time against