SWGEMU-488 [Added] Clothing Bio Tissues now work

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Ivojedi	Author	43m	1	I moved the loading of the bio_skill_mods.lua file to Cra...
TheAnswer	Moderator	1m
Itac	Reviewer - 0% complete
Loshult	Reviewer - 100% complete	15m	1	This type of data does not belong in the object. It shoul...
cRush	Reviewer - 0% complete
dannuic	Reviewer - 0% complete
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 2% complete	6m
Total		1h 4m	2

Files: 43
Patches:
- clothingBioTissues.patch: (anchored to : / )
- clothingBioTissues2.patch: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )
- clothing_bio_tissues3.patch: (anchored to swgemu : core3/trunk/MMOCoreORB/ )

#permalink

Objectives

[Added] Clothing Bio Tissues can now be crafted with proper skill mods and are properly passed onto clothing components and then on to clothing.

Known issue: when crafting the tissues pre-assembly, the crafting pane still lists the skill mods as Mod Five, etc. The correct skill mods display properly once assembly is complete.

I'm really not sure how to change the display at that first step.

Second patch Update: I removed some extraneous debugging code and some experimental code I had commented but forgot to remove before uploading the first time. I also included TangibleObject.h and TangibleObject.cpp which were omitted from the first patch.

#permalink

Summary

Patch committed to unstable branch.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

/bin/scripts/crafting/bio_skill_mods.lua Added #permalink
Click to load diff

/bin/.../bio/bio_component_clothing_casual_entertainer.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_clothing_casual_entertainer_2.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_clothing_casual_medic.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_clothing_casual_medic_2.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_clothing_casual_taming.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_clothing_casual_taming_2.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_clothing_field_bleeding.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_clothing_field_bleeding_2.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_clothing_field_camo.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_clothing_field_camo_2.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_clothing_field_cover.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_clothing_field_cover_2.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_clothing_field_defense.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_clothing_field_defense_2.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_clothing_field_intimidate.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_clothing_field_intimidate_2.lua Changed #permalink
Click to load diff

/src/server/.../tangible/TangibleObject.cpp Changed #permalink
Click to load diff

/src/server/.../tangible/TangibleObject.h Changed #permalink
Click to load diff

/src/server/.../tangible/TangibleObject.idl Changed #permalink
Click to load diff

/src/.../tangible/TangibleObjectImplementation.cpp Changed 2 (0) #permalink
Click to load diff

/workspace/.../crafting/bio_skill_mods.lua Added #permalink
Click to load diff

/workspace/.../bio/bio_component_clothing_casual_entertainer.lua Changed #permalink
Click to load diff

/workspace/.../bio/bio_component_clothing_casual_entertainer_2.lua Changed #permalink
Click to load diff

/workspace/.../bio/bio_component_clothing_casual_medic.lua Changed #permalink
Click to load diff

/workspace/.../bio/bio_component_clothing_casual_medic_2.lua Changed #permalink
Click to load diff

/workspace/.../bio/bio_component_clothing_casual_taming.lua Changed #permalink
Click to load diff

/workspace/.../bio/bio_component_clothing_casual_taming_2.lua Changed #permalink
Click to load diff

/workspace/.../bio/bio_component_clothing_field_bleeding.lua Changed #permalink
Click to load diff

/workspace/.../bio/bio_component_clothing_field_bleeding_2.lua Changed #permalink
Click to load diff

/workspace/.../bio/bio_component_clothing_field_camo.lua Changed #permalink
Click to load diff

/workspace/.../bio/bio_component_clothing_field_camo_2.lua Changed #permalink
Click to load diff

/workspace/.../bio/bio_component_clothing_field_cover.lua Changed #permalink
Click to load diff

/workspace/.../bio/bio_component_clothing_field_cover_2.lua Changed #permalink
Click to load diff

/workspace/.../bio/bio_component_clothing_field_defense.lua Changed #permalink
Click to load diff

/workspace/.../bio/bio_component_clothing_field_defense_2.lua Changed #permalink
Click to load diff

/workspace/.../bio/bio_component_clothing_field_intimidate.lua Changed #permalink
Click to load diff

/workspace/.../bio/bio_component_clothing_field_intimidate_2.lua Changed #permalink
Click to load diff

/workspace/.../crafting/CraftingManager.cpp Changed #permalink
Click to load diff

/workspace/.../crafting/CraftingManager.h Changed #permalink
Click to load diff

/workspace/.../crafting/CraftingManager.idl Changed #permalink
Click to load diff

/workspace/.../crafting/CraftingManagerImplementation.cpp Changed #permalink
Click to load diff

/workspace/.../tangible/TangibleObjectImplementation.cpp Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-488

[Added] Clothing Bio Tissues now work

Closed on 04 Jan

Author

Moderator

Reviewers

SWGEMU-488 2 (0)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-488

[Added] Clothing Bio Tissues now work

Closed on 04 Jan

Author

Moderator

Reviewers

SWGEMU-488 2 (0)

Summarize the review outcomes (optional)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Create Issue

Log time against