SWGEMU-477 (unstable) Adjusted corpse despawn times and logic to be more inline with SOE Publish 14.1

Details
Objectives
Summary
General Comments 3 (0)

pasted.patch (5 months and 8 days ago) 0 (0)
- src/server/zone 0 (0)
  - managers 0 (0)
    - creature 0 (0)
      - CreatureManagerImplementation.cpp 0 (0) x
    - player 0 (0)
      - PlayerManager.idl 0 (0) x
      - PlayerManagerImplementation.cpp 0 (0) x
  - objects/creature 0 (0)
    - CreatureImplementation.cpp 0 (0) x
pasted.patch (5 months ago) 0 (0)
- src/server/zone 0 (0)
  - managers 0 (0)
    - creature 0 (0)
      - CreatureManagerImplementation.cpp 7 (0) x
    - player 0 (0)
      - PlayerManager.idl 0 (0) x
      - PlayerManagerImplementation.cpp 15 (0) x
  - objects/creature 0 (0)
    - CreatureImplementation.cpp 0 (0) x
idl-patch.txt (4 months and 28 days ago) 0 (0)
- src/server/zone 0 (0)
  - managers 0 (0)
    - creature 0 (0)
      - CreatureManagerImplementation.cpp 2 (0) x
    - player 0 (0)
      - PlayerManager.cpp 0 (0) x
      - PlayerManager.h 0 (0) x
      - PlayerManager.idl 4 (0) x
      - PlayerManagerImplementation.cpp 7 (0) x
  - objects/creature 0 (0)
    - CreatureImplementation.cpp 0 (0) x
patch-2.txt (4 months and 18 days ago) 0 (0)
- src/server/zone 0 (0)
  - managers 0 (0)
    - creature 0 (0)
      - CreatureManagerImplementation.cpp 4 (0) x
    - player 0 (0)
      - PlayerManager.cpp 0 (0) x
      - PlayerManager.h 0 (0) x
      - PlayerManager.idl 2 (0) x
      - PlayerManagerImplementation.cpp 2 (0) x
  - objects/creature 0 (0)
    - CreatureImplementation.cpp 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Nathan Klick	Author	1h 59m	24	Uploaded patch file containing the IDL changes and still ...
TheAnswer	Moderator	1m
Itac	Reviewer - 0% complete
Loshult	Reviewer - 100% complete	46m	10	Try that next time. I don't know if it makes any differen...
cRush	Reviewer - 0% complete
dannuic	Reviewer - 65% complete	36m	9	that is what I'm saying. I am pretty sure we had it this ...
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 55% complete	9m	3	Yes it was rebooted and it seems to have resolved some of...
Total		3h 30m	46

Files: 20
Patches:
- pasted.patch: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )
- pasted.patch: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )
- idl-patch.txt: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )
- patch-2.txt: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )

#permalink

Objectives

Modify creature despawn logic to be more like the SOE publish 14.1 despawn logic.
Despawn corpses immediately if nothing to loot or harvest.
Consider group members in range (< 128m) when making despawn decisions.
Increase despawn time for creature corpses back to 5 minutes when looting or harvesting can be performed.

#permalink

Summary

Patch committed to unstable branch.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

11 Dec 12

Nathan Klick says:

After many different opinions from the forum thread below I believe the general consensus to be that the current despawn time of 45 seconds is way too short. Many players including myself also feel that the SOE servers had a despawn time of 5 minutes and when a corpse was looted and/or harvested it despawned immediately. I understand the concern (in terms of load and resource consumption) for having all corpses unconditionally hang around for 5 minutes. However this patch is intended to offer a best of both blend that more closely mirrors the SOE live servers behavior at the time of publish 14.1. In this patch I increase the despawn time back to 5 minutes but have also added logic to despawn corpses immediately if they have been looted and harvested. There are also conditions in place to handle users who cannot harvest and creatures with no loot. The code takes other group members in range (<= 128m) into account when determining whether the corpse should immediately despawn or not. I have tested this thoroughly in my dev environment setup based on the Debian VMWare image.

Forum Thread: http://www.swgemu.com/forums/showthread.php?t=68219&p=525717#post525717

Thanks,

Nathan

#permalink

17 Dec 12

Loshult says:

Please go through the patch and remove all extra new lines that you added. We have at most one empty line between statements.

#permalink

18 Dec 12

Nathan Klick says:

Updated & attached new patch to remove the extraneous whitespace as requested. Please let me know if there is anything else I need to change.

Thanks,

Nathan

#permalink

/src/.../creature/CreatureManagerImplementation.cpp Changed #permalink
Click to load diff

/src/server/.../player/PlayerManager.idl Changed #permalink
Click to load diff

/src/.../player/PlayerManagerImplementation.cpp Changed #permalink
Click to load diff

/src/.../creature/CreatureImplementation.cpp Changed #permalink
Click to load diff

/src/.../creature/CreatureManagerImplementation.cpp Changed 7 (0) #permalink
Click to load diff

/src/server/.../player/PlayerManager.idl Changed #permalink
Click to load diff

/src/.../player/PlayerManagerImplementation.cpp Changed 15 (0) #permalink
Click to load diff

/src/.../creature/CreatureImplementation.cpp Changed #permalink
Click to load diff

/src/.../creature/CreatureManagerImplementation.cpp Changed 2 (0) #permalink
Click to load diff

/src/server/.../player/PlayerManager.cpp Changed #permalink
Click to load diff

/src/server/.../player/PlayerManager.h Changed #permalink
Click to load diff

/src/server/.../player/PlayerManager.idl Changed 4 (0) #permalink
Click to load diff

/src/.../player/PlayerManagerImplementation.cpp Changed 7 (0) #permalink
Click to load diff

/src/.../creature/CreatureImplementation.cpp Changed #permalink
Click to load diff

/src/.../creature/CreatureManagerImplementation.cpp Changed 4 (0) #permalink
Click to load diff

/src/server/.../player/PlayerManager.cpp Changed #permalink
Click to load diff

/src/server/.../player/PlayerManager.h Changed #permalink
Click to load diff

/src/server/.../player/PlayerManager.idl Changed 2 (0) #permalink
Click to load diff

/src/.../player/PlayerManagerImplementation.cpp Changed 2 (0) #permalink
Click to load diff

/src/.../creature/CreatureImplementation.cpp Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-477

(unstable) Adjusted corpse despawn times and logic to be more inline with SOE Publish 14.1

Closed on 04 Jan

Author

Moderator

Reviewers

SWGEMU-477 46 (0)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Nathan Klick says:

Loshult says:

Nathan Klick says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-477

(unstable) Adjusted corpse despawn times and logic to be more inline with SOE Publish 14.1

Closed on 04 Jan

Author

Moderator

Reviewers

SWGEMU-477 46 (0)

Summarize the review outcomes (optional)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Nathan Klick says:

Loshult says:

Nathan Klick says:

Create Issue

Log time against