SWGEMU-468 (unstable)(fixed)Mantis #0003587 Reduced Maintenance Fees for Merchants

Details
Objectives
Summary
General Comments 4 (0)

pasted.patch (5 months and 8 days ago) 0 (0)
- src/server/zone/managers/structure 0 (0)
  - StructureManager.cpp 2 (0) x
pasted.patch (3 months and 23 days ago) 0 (0)
- src/server/zone/managers/structure 0 (0)
  - StructureManager.cpp 1 (0) x
pasted.patch (3 months and 19 days ago) 0 (0)
- src/server/zone 0 (0)
  - managers/structure 0 (0)
    - StructureManager.cpp 0 (0) x
  - objects/structure 0 (0)
    - StructureObjectImplementation.cpp 2 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Galameed	Author	1h 30m	4	I thought that the bonus should only be applied when the ...
TheAnswer	Moderator	1m
Itac	Reviewer - 0% complete
Loshult	Reviewer - 50% complete	22m	5	You still need to run this code here otherwise the mainte...
cRush	Reviewer - 0% complete
dannuic	Reviewer - 0% complete	1m
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 0% complete	0m
Total		1h 54m	9

Files: 4
Patches:
- pasted.patch: (anchored to : / )
- pasted.patch: (anchored to : / )
- pasted.patch: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )
- pasted.patch: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )

#permalink

Objectives

Added additional checks when paying maintenance to structures to ensure that the paying player is entitled to reduced maintenance fees. Updated 28JAN2013

#permalink

Summary

Patch committed to unstable branch.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

17 Dec 12

Loshult says:

This is already handled in StructureObjectImplementation.cpp, line 275-280.

#permalink

18 Dec 12

Galameed says:

Yes I know that it is however my all the buildings are calling that event. I added it in another spot to address the different buildings

#permalink

26 Jan

Loshult says:

Remove the code in StructureObjectImplementation and ensure that all types of paying maintenance uses the payMaintenance method in the structure manager instead.

#permalink

28 Jan

Ok Code removed in StructureObjectImplementation. I have tested it on several factories and homes and it appears to still work as intended. The reduced fees also appear to go away when a player without the skill pays maintenance as well.

#permalink

/src/server/.../structure/StructureManager.cpp Changed 2 (0) #permalink
Click to load diff

/src/server/.../structure/StructureManager.cpp Changed 1 (0) #permalink
Click to load diff

/src/server/.../structure/StructureManager.cpp Changed #permalink
Click to load diff

/src/.../structure/StructureObjectImplementation.cpp Changed 2 (0) #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-468

(unstable)(fixed)Mantis #0003587 Reduced Maintenance Fees for Merchants

Closed on 07 Feb

Author

Moderator

Reviewers

SWGEMU-468 9 (0)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Loshult says:

Galameed says:

Loshult says:

Galameed says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-468

(unstable)(fixed)Mantis #0003587 Reduced Maintenance Fees for Merchants

Closed on 07 Feb

Author

Moderator

Reviewers

SWGEMU-468 9 (0)

Summarize the review outcomes (optional)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Loshult says:

Galameed says:

Loshult says:

Galameed says:

Create Issue

Log time against