SWGEmu SWGEMU-463

[Added] Screenplay to populate the Giant Bark Mite Cave on Rori

Closed on 12 Dec 12

  •  
  •  
  •  
  •  
  • Author
  • Moderator
  • Reviewers
    • Reviewer completed

SWGEMU-463 5

Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 26m 3 All of those files should have changes.
Moderator      
Reviewer - 0% complete      
Reviewer - 0% complete      
Reviewer - 0% complete      
Reviewer - 0% complete      
oru
Reviewer - 0% complete      
Reviewer - 0% complete      
Reviewer - 100% complete 7m 2 OK. Just trying to figure out if "no change' is accurate ...
Total   33m 5  
#permalink

Objectives

[Added] Screenplay to populate the Giant Bark Mite Cave on Rori

#permalink

Summary

Pushed to Nova

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

12 Dec 12

elpete says:

Looks like there is some kind of display problem with your mobile files? How are you submitting them?

Or is it including files that don't have any changes?

12 Dec 12

Ivojedi says:

I'm really not sure what is going on with them. If you look at the pasted patch, the changes are there, but for some reason they are not displaying when you click the files to the left.

12 Dec 12

Ivojedi says:

As a follow-up, this seems to be happening to my other, more recent patches, and also happened with swgemu-454, which you committed already. I suspect this issue is the reason that you had initially missed the mobile files in your commit of that patch. Also, if it helps, I did not have this issue on a previous patch, swgemu-448. It may or may not be relevant, but 448 was before you were added as a default reviewer and all the rest with the issue were after that. Perhaps something changed at the same time you were added as a default reviewer?

12 Dec 12

elpete says:

OK. Just trying to figure out if "no change' is accurate or not.

12 Dec 12

Ivojedi says:

All of those files should have changes.

/bin/.../rori/giant_mutant_bark_mite.lua Changed  
Open in IDE #permalink
/bin/.../rori/mutant_bark_mite_hatchiing.lua Changed  
Open in IDE #permalink
/bin/.../rori/mutant_bark_mite_hatchling.lua Added  
Open in IDE #permalink
/bin/.../rori/mutant_bark_mite_queen.lua Changed  
Open in IDE #permalink
/bin/.../rori/mutant_bark_mite_soldier.lua Changed  
Open in IDE #permalink
/bin/.../rori/mutant_bark_mite_worker.lua Changed  
Open in IDE #permalink
/bin/scripts/mobile/rori/serverobjects.lua Changed  
Open in IDE #permalink
/bin/.../caves/rori_giant_bark_mite_cave.lua Added  
Open in IDE #permalink
/bin/scripts/screenplays/screenplay.lua Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create Issue

X
Assign To Me

Log time against