This is a list of all comments for SWGEMU-462.

Review Summary: Patch submitted to unstable branch.


----------------------------------------
File: src/server/zone/managers/group/GroupManager.cpp
Revision Comment by elpete on 06 December 2012, 08:59 
http://www.swgemu.com/fisheye/cru/SWGEMU-462#c1031

  Were you using 2 for your testing?

  Reply by Cebot on 06 December 2012, 10:13
  > Crap. Yes - wasn't going to try getting 20 chars online on
  > one client machine :)
  > 
  > Though it strikes me as bad practice to have had this
  > hard-coded in the first place, rather than as a config
  > parameter (or a constant at the very least).

    Reply by Cebot on 06 December 2012, 10:15
    > And in retrospect, I should also have changed the existing
    > check to >=, rather than ==, just in case some weird
    > condition happens that would have allowed a 21st person,
    > and therefore 22, 23, etc.


---

ID: SWGEMU-462 http://www.swgemu.com/fisheye/cru/SWGEMU-462

Title: Group Invite Messages & LFG
Statement of Objectives:
Currently, a leader can attempt to invite players even if the group is full. The leader doesn't get any kind of system message, but the person being invited gets the @group:full message ("You may not invite someone while your group is full."). The check that's currently being done for the invitee should instead be done for the leader.

The invitee also needs a check, though, in case the group filled up while they waited to accept. In this case, the appropriate message is "The group is full."

Also, the LFG flag was not being properly cleared once forming or joining a group.

State: Closed

Summary: Patch submitted to unstable branch.

Author: Cebot
Moderator: TheAnswer
Reviewers: (6 active, 1 completed*)
     Loshult   (*)
     Itac
     cRush
     dannuic
     oru
     Kyle
     elpete