SWGEMU-461 BE Tissue experimentation percentages

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Bert	Author	9m	2	All but one was done already in the schematic tool, so I ...
TheAnswer	Moderator
Itac	Reviewer - 0% complete
Loshult	Reviewer - 100% complete	17m	2	I haven't checked if these changes have been made in the ...
cRush	Reviewer - 0% complete
dannuic	Reviewer - 0% complete	2m	1	How did you get these? These properties were pulled from ...
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 0% complete	0m
Total		28m	5

Files: 12
Patches:
- patch.txt: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )

#permalink

Objectives

[fix] BE tissue experimentation percentages - Mantis 3086

#permalink

Summary

Patch committed to unstable branch.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

05 Dec 12

dannuic says:

How did you get these? These properties were pulled from the client iirc.

EDIT: Oh, I see... I'm afraid to edit these values like this since I'm not sure how this will interfere with kyle's crafting system.

#permalink

01 Feb

Loshult says:

Can you do these changes in the crafting tool and verify that the changes you do have the desired effect?

#permalink

03 Feb

Bert says:

I found that these changes were done in the schematic tool, so does that mean that they will change next update? They do have the desired effect when I tested them. If they were changed in the schematic tool and this isn't needed, then I can abandon the review.

#permalink

03 Feb

Loshult says:

I haven't checked if these changes have been made in the schematic tool, but I don't think they have since they should have been committed then. Please do the change in the schematic tool as well so that these changes will stay even if we do a format change of the lua files later and exports every schematic again. Get hold of me on IRC if you need access to the schematic too.

#permalink

04 Feb

Bert says:

All but one was done already in the schematic tool, so I then changed that one to match. All set.

#permalink

/bin/.../bio/bio_component_food_heavy_filling.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_food_heavy_flavor.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_food_heavy_nutrition.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_food_heavy_quantity.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_food_light_filling.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_food_light_flavor.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_food_light_nutrition.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_food_light_quantity.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_food_medium_filling.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_food_medium_flavor.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_food_medium_nutrition.lua Changed #permalink
Click to load diff

/bin/.../bio/bio_component_food_medium_quantity.lua Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-461

BE Tissue experimentation percentages

Closed on 05 Feb

Author

Moderator

Reviewers

SWGEMU-461 5 (0)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

dannuic says:

Loshult says:

Bert says:

Loshult says:

Bert says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-461

BE Tissue experimentation percentages

Closed on 05 Feb

Author

Moderator

Reviewers

SWGEMU-461 5 (0)

Summarize the review outcomes (optional)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

dannuic says:

Loshult says:

Bert says:

Loshult says:

Bert says:

Create Issue

Log time against