SWGEMU-387 Fix for group invite bug

Details
Objectives
General Comments 3 (0)

groupmanager.patch (8 months ago) 0 (0)
- src/server/zone/managers/group 0 (0)
  - GroupManager.cpp 2 (0) x
groupmanager.patch (8 months ago) 0 (0)
- src/server/zone/managers/group 0 (0)
  - GroupManager.cpp 0 (0) x
groupmanager.patch (8 months ago) 0 (0)
- src/server/zone/managers/group 0 (0)
  - GroupManager.cpp 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
elpete	Author	16m	2	No. it isn't committed. I have been waiting for an OK bef...
TheAnswer	Moderator	3m	3	commit it
Itac	Reviewer - 0% complete
Loshult	Reviewer - 100% complete	30m
cRush	Reviewer - 0% complete
dannuic	Reviewer - 0% complete
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
Total		49m	5

Files: 3
Patches:
- groupmanager.patch: (anchored to : / )
- groupmanager.patch: (anchored to : / )
- groupmanager.patch: (anchored to swgemu : core3/trunk/MMOCoreORB/ )

#permalink

Objectives

Fix for http://www.swgemu.com/bugs/view.php?id=3218

Issue is
Player1 invites Player2 to a group
Player2 doesn't acccept immediately
Player1 gets invite from Player3 and accepts.
Player2 accepts original invite and is put in Player3's group

This patch doesn't let Player2 join the group and provides an error message.

If Player2 joins Player3's group and is given leadership of the group, then Player2 will be put in the group if he accepts the invite.

Reproduced and tested on dev.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

12 Oct 12

TheAnswer says:

did you commit this?

#permalink

13 Oct 12

elpete says:

No. it isn't committed. I have been waiting for an OK before committing anything.

#permalink

13 Oct 12

TheAnswer says:

commit it

#permalink

/src/server/.../group/GroupManager.cpp Changed 2 (0) #permalink
Click to load diff

/src/server/.../group/GroupManager.cpp Changed #permalink
Click to load diff

/src/server/.../group/GroupManager.cpp Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-387

Fix for group invite bug

Closed on 13 Oct 12

Author

Moderator

Reviewers

SWGEMU-387 5 (0)

Details

Objectives

Issues Raised From Comments

General Comments

TheAnswer says:

elpete says:

TheAnswer says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-387

Fix for group invite bug

Closed on 13 Oct 12

Author

Moderator

Reviewers

SWGEMU-387 5 (0)

Summarize the review outcomes (optional)

Details

Objectives

Issues Raised From Comments

General Comments

TheAnswer says:

elpete says:

TheAnswer says:

Create Issue

Log time against