This is a list of all comments for SWGEMU-338.

Review Summary: No summary

General Comment by dannuic on 24 July 2012, 12:08 
http://www.swgemu.com/fisheye/cru/SWGEMU-338#c800

  Please fix if this is still relevant, or abandon if it is not.

  Reply by Kreen on 24 July 2012, 12:39
  > I did fix a lot of the comments in another pasted.patch. You
  > should see two on the side, one from 18 days ago and one from
  > 8 days ago. The 8 days ago is the most recent. Lemme know if
  > you can't see it (I couldn't figure out how to edit my
  > previous patch, so Kell told me to just submit a new one)

    Reply by dannuic on 24 July 2012, 12:45
    > remove the anchor from the previous patch

      Reply by Kreen on 24 July 2012, 15:20
      > Done! I think..

General Comment by TheAnswer on 07 October 2012, 15:09 
http://www.swgemu.com/fisheye/cru/SWGEMU-338#c847

  commiting this and fixing some of your errors


----------------------------------------
File: src/server/zone/objects/creature/commands/BroadcastAreaCommand.h
Revision Comment by TheAnswer on 11 July 2012, 20:29 
http://www.swgemu.com/fisheye/cru/SWGEMU-338#c679

  using close objects this way is not thread safe
  check SceneObjectImplementation::broadcastMessagePrivate

----------------------------------------
File: src/server/zone/objects/creature/commands/BroadcastGalaxyCommand.h
Revision Comment by dannuic on 14 July 2012, 15:30 
http://www.swgemu.com/fisheye/cru/SWGEMU-338#c731

  ghost == NULL isn't insufficient perms. It should return
  GENERALERROR, which is what the lines you deleted essentially
  do

  Reply by Kreen on 14 July 2012, 16:19
  > Oh I see what happened. Compare these two:
  > https://trac.assembla.com/swgemu/browser/core3/trunk/MMOCoreORB/src/server/zone/objects/creature/commands/BroadcastGalaxyCommand.h
  > https://trac.assembla.com/swgemu/browser/core3/trunk/MMOCoreORB/src/server/zone/objects/creature/commands/BroadcastCommand.h
  > 
  > I started working on BroadcastCommand, which doesn't have the
  > isPlayerCreature() check for creature. Then I copied it over
  > to the other broadcasts and modified from there. I'll add
  > that check back in to all of them

----------------------------------------
File: src/server/zone/objects/creature/commands/BroadcastPlanetCommand.h
Revision Comment by TheAnswer on 11 July 2012, 20:27 
http://www.swgemu.com/fisheye/cru/SWGEMU-338#c676

  You need to lock chat manager when using the player map
  Locker chatManagerLocker(chatManager);

  Reply by Kreen on 11 July 2012, 22:25
  > If I lock it up here, do I have to lock it again in your
  > other two comments?

    Reply by cRush on 17 July 2012, 13:47
    > Yes. It's only locked in this scope.

Revision Comment by TheAnswer on 11 July 2012, 20:28 
http://www.swgemu.com/fisheye/cru/SWGEMU-338#c677

  ChatManager should be locked when doing this

Revision Comment by TheAnswer on 11 July 2012, 20:28 
http://www.swgemu.com/fisheye/cru/SWGEMU-338#c678

  ChatManager lock

----------------------------------------
File: src/server/zone/objects/creature/commands/KillCommand.h
Revision Comment by TheAnswer on 11 July 2012, 20:25 
http://www.swgemu.com/fisheye/cru/SWGEMU-338#c675

  check my other comment in KillPlayerCommand
  You need a a safe copy of the close objects.
  Doing it this way is not thread safe

----------------------------------------
File: src/server/zone/objects/creature/commands/KillPlayerCommand.h
Revision Comment by TheAnswer on 11 July 2012, 20:23 
http://www.swgemu.com/fisheye/cru/SWGEMU-338#c674

  this is wrong
  you need to use another vector and use safeCopyTo() 
  check SceneObjectImplementation::broadcastMessagePrivate, etc..

  Reply by Kreen on 11 July 2012, 22:27
  > What I did was copy getNearbyCraftingStation() from
  > PlayerManagerImplementation verbatim, since I don't know how
  > to use closeobjects
  > The only thing I can notice is that you lock the zone before
  > getting closeobjects in the Player one, and I didn't.
  > 
  > As far as figuring out what you're doing in the
  > SceneObjectImplementation... I'll need to chat with you on
  > IRC some lol

    Reply by cRush on 17 July 2012, 13:48
    > What he's saying is the above line gets a pointer directly
    > to the closeObjects vector of creature. In order to use
    > that vector, you'd have to lock Zone for the entire
    > iteration. Instead, by using safeCopyTo(), you get a copy
    > of the closeObjects vector, in which case you don't have to
    > lock anything while iterating because the copy can't be
    > modified by another thread.


---

ID: SWGEMU-338 http://www.swgemu.com/fisheye/cru/SWGEMU-338

Title: Admin Commands for ECs
Statement of Objectives:
This patch changes the following:

- Removes [ - ] from broadcast in chatimplementation (for more event-suited broadcasts)
- Adds Event, Imperial, and Rebel broadcast options
- Implements broadcastArea and broadcastPlanet (broadcast and broadcastGalaxy are functionally identical for now)
- Adds faction option to broadcastGalaxy in chatimplementation
- Expands kill to deal area and HAM-specific damage. Will not kill players
- Implements killPlayer similar to kill. Will ONLY kill players (useful to area kill creatures with nearby players)
- All commands take a -H or -help option to explain syntax

State: Closed

Summary: 

Author: Kreen
Moderator: TheAnswer
Reviewers: (9 active, 0 completed*)
     Loshult
     Moncai
     lordkator
     cRush
     dannuic
     oru
     Anakis
     Polonel
     Kyle