SWGEMU-299 [Fixed] healing bugs - Updated 12/25

Details
Objectives
Summary
General Comments 7 (0)

noforcebug-v2.txt (11 months ago) 0 (0)
- src/server/zone/objects/creature/commands 0 (0)
  - ForceCureDiseaseCommand.h 1 (0) x
  - ForceCurePoisonCommand.h 1 (0) x
  - HealActionWoundOther1Command.h 1 (0) x
  - HealActionWoundOther2Command.h 2 (0) x
noforcebug-v4.txt (5 months and 18 days ago) 0 (0)
- src/server/zone/objects/creature/commands 0 (0)
  - ForceCureDiseaseCommand.h 2 (0) x
noforcebug-v5.txt (4 months and 28 days ago) 0 (0)
- src/server/zone/objects/creature/commands 0 (0)
  - ForceCureDiseaseCommand.h 1 (0) x
  - ForceCurePoisonCommand.h 0 (0) x
  - HealActionSelf1Command.h 0 (0) x
  - HealActionSelf2Command.h 0 (0) x
  - HealActionWoundOther1Command.h 2 (0) x
  - HealActionWoundOther2Command.h 0 (0) x
  - HealActionWoundSelf1Command.h 1 (0) x
  - HealAllOther1Command.h 1 (0) x
  - HealAllOther2Command.h 0 (0) x
  - HealAllSelf1Command.h 0 (0) x
  - HealAllSelf2Command.h 0 (0) x
  - HealBattleFatigueSelf1Command.h 0 (0) x
  - HealBattleFatigueSelf2Command.h 0 (0) x
  - HealHealthSelf1Command.h 0 (0) x
  - HealHealthSelf2Command.h 0 (0) x
  - HealHealthWoundOther1Command.h 0 (0) x
  - HealHealthWoundOther2Command.h 0 (0) x
  - HealHealthWoundSelf1Command.h 0 (0) x
  - HealHealthWoundSelf2Command.h 0 (0) x
  - HealMindSelf1Command.h 0 (0) x
  - HealMindSelf2Command.h 0 (0) x
  - HealMindWoundOther1Command.h 0 (0) x
  - HealMindWoundOther2Command.h 0 (0) x
  - HealMindWoundSelf1Command.h 0 (0) x
  - HealMindWoundSelf2Command.h 0 (0) x
  - HealStatesOtherCommand.h 0 (0) x
  - HealStatesSelfCommand.h 0 (0) x
  - StopBleedingCommand.h 0 (0) x
  - TotalHealOtherCommand.h 0 (0) x
  - TotalHealSelfCommand.h 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
bluree	Author	3h 3m	4	Valk and I are putting Jedi on hold for right now. We wi...
TheAnswer	Moderator	3m
cRush	Reviewer - 0% complete	8m	5	Please read comments, then look over all commands again.
Loshult	Reviewer - 40% complete	57m	10	Any progress on this?
Valkyra	Reviewer - 11% complete	2m
dannuic	Reviewer - 25% complete	13m
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
Total		4h 27m	19

Files: 35
Patches:
- noforcebug-v2.txt: (anchored to : / )
- noforcebug-v3.txt: (anchored to : / )
- noforcebug-v4.txt: (anchored to : / )
- noforcebug-v5.txt: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )

#permalink

Objectives

12/25
—
noforcebug-v5.txt

[Changed] Healing to use StringID.
[Fixed] Misc code cleanup.

12/01
—
noforcebug-v4.txt

[Fixed] Totalheal with 0 force.
[Fixed] Misc healother skills.
[Fixed] Faction/BH target healing.
Corrected several typo's as suggested by cRush in noforcebug-v2.txt

*****

[Fixed] Totalheal with 0 force.
[Fixed] Misc healother skills.

06/21

adding crush to review as he is taking over jedi

#permalink

Summary

CLosing this since no more work is expected.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

13 Jul 12

cRush says:

Please read comments, then look over all commands again.

#permalink

17 Jul 12

bluree says:

will fix and patch late tonight

#permalink

12 Dec 12

Loshult says:

Use http://ocdsoft.com/strings.php to find the used string id's for every command. jedi_spam.stf and healing_response.stf has probably got all the string id's needed for this.

Go through all commands and find the correct string ids, ensure that both healer and target receives system messages.

#permalink

26 Dec 12

bluree says:

changed to use stringID's

and updated system msg to healer & target(only dmg & wounds supposed to send msg to target)

#permalink

26 Dec 12

Loshult says:

It seems like we have a lot of code duplication in these commands. Each command performs almost the same checks (this is especially true for the different strengths of each command). I think it might be possible to make one or a few more generic command(s) that each specialized command inherits and defines exactly what to do. Please check how the TendCommand.h, TendDamageCommand.h and TendWoundCommand.h does this.

It might also be good to divide this patch into several smaller ones to make it easier to review and fix.

#permalink

01 Feb

Loshult says:

Any progress on this?

#permalink

04 Feb

bluree says:

Valk and I are putting Jedi on hold for right now.

We will come back to it later on down the road once more of the base game is complete and the 'Jedi frenzy' has died down..

#permalink

/src/.../commands/ForceCureDiseaseCommand.h Changed 1 (0) #permalink
Click to load diff

/src/.../commands/ForceCurePoisonCommand.h Changed 1 (0) #permalink
Click to load diff

/src/.../commands/HealActionWoundOther1Command.h Changed 1 (0) #permalink
Click to load diff

/src/.../commands/HealActionWoundOther2Command.h Changed 2 (0) #permalink
Click to load diff

/src/.../commands/ForceCureDiseaseCommand.h Changed 2 (0) #permalink
Click to load diff

/src/.../commands/ForceCureDiseaseCommand.h Changed 1 (0) #permalink
Click to load diff

/src/.../commands/ForceCurePoisonCommand.h Changed #permalink
Click to load diff

/src/.../commands/HealActionSelf1Command.h Changed #permalink
Click to load diff

/src/.../commands/HealActionSelf2Command.h Changed #permalink
Click to load diff

/src/.../commands/HealActionWoundOther1Command.h Changed 2 (0) #permalink
Click to load diff

/src/.../commands/HealActionWoundOther2Command.h Changed #permalink
Click to load diff

/src/.../commands/HealActionWoundSelf1Command.h Changed 1 (0) #permalink
Click to load diff

/src/.../commands/HealAllOther1Command.h Changed 1 (0) #permalink
Click to load diff

/src/.../commands/HealAllOther2Command.h Changed #permalink
Click to load diff

/src/server/.../commands/HealAllSelf1Command.h Changed #permalink
Click to load diff

/src/server/.../commands/HealAllSelf2Command.h Changed #permalink
Click to load diff

/src/.../commands/HealBattleFatigueSelf1Command.h Changed #permalink
Click to load diff

/src/.../commands/HealBattleFatigueSelf2Command.h Changed #permalink
Click to load diff

/src/.../commands/HealHealthSelf1Command.h Changed #permalink
Click to load diff

/src/.../commands/HealHealthSelf2Command.h Changed #permalink
Click to load diff

/src/.../commands/HealHealthWoundOther1Command.h Changed #permalink
Click to load diff

/src/.../commands/HealHealthWoundOther2Command.h Changed #permalink
Click to load diff

/src/.../commands/HealHealthWoundSelf1Command.h Changed #permalink
Click to load diff

/src/.../commands/HealHealthWoundSelf2Command.h Changed #permalink
Click to load diff

/src/.../commands/HealMindSelf1Command.h Changed #permalink
Click to load diff

/src/.../commands/HealMindSelf2Command.h Changed #permalink
Click to load diff

/src/.../commands/HealMindWoundOther1Command.h Changed #permalink
Click to load diff

/src/.../commands/HealMindWoundOther2Command.h Changed #permalink
Click to load diff

/src/.../commands/HealMindWoundSelf1Command.h Changed #permalink
Click to load diff

/src/.../commands/HealMindWoundSelf2Command.h Changed #permalink
Click to load diff

/src/.../commands/HealStatesOtherCommand.h Changed #permalink
Click to load diff

/src/.../commands/HealStatesSelfCommand.h Changed #permalink
Click to load diff

/src/server/.../commands/StopBleedingCommand.h Changed #permalink
Click to load diff

/src/.../commands/TotalHealOtherCommand.h Changed #permalink
Click to load diff

/src/.../commands/TotalHealSelfCommand.h Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-299

[Fixed] healing bugs - Updated 12/25

Closed on 05 Feb

Author

Moderator

Reviewers

SWGEMU-299 19 (0)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

cRush says:

bluree says:

Loshult says:

bluree says:

Loshult says:

Loshult says:

bluree says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-299

[Fixed] healing bugs - Updated 12/25

Closed on 05 Feb

Author

Moderator

Reviewers

SWGEMU-299 19 (0)

Summarize the review outcomes (optional)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

cRush says:

bluree says:

Loshult says:

bluree says:

Loshult says:

Loshult says:

bluree says:

Create Issue

Log time against