•  

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 33
Last Commit: 19 Mar
Commits this week: 0
Total Lines of Code (LoC): 373,120
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 25 Mar
5:09 am

max_alex

  • More
  • CR-3
  • Abandoned
Friday 16 Nov 2012
8:35 pm

scattrrbrain

8:35 pm

scattrrbrain

  • More
  • CR-2
  • Abandoned
Thursday 11 Oct 2012
5:57 pm

scattrrbrain

line 53 should mention "poolsToDamage = HEALTH_ATTRIBUTE + ACTION_ATTRIBUTE + MIND_ATTRIBUTE,"

line 53 should mention "poolsToDamage = HEALTH_ATTRIBUTE + ACTION_ATTRIBUTE + MIND_ATTRIBUTE,"

5:55 pm

scattrrbrain

line 53 should mention "poolsToDamage = HEALTH_ATTRIBUTE + ACTION_ATTRIBUTE + MIND_ATTRIBUTE,"

line 53 should mention "poolsToDamage = HEALTH_ATTRIBUTE + ACTION_ATTRIBUTE + MIND_ATTRIBUTE,"

Friday 13 Jul 2012
6:38 pm

TheAnswer

6:37 pm

cRush

6:37 pm

cRush

Friday 19 Aug 2011
7:11 am

cRush

7:11 am

cRush

Sunday 26 Jun 2011
6:54 am

cRush

This is impossible. You are checking to see if the session is null, which you used getActiveSession to retrieve. So if it is null, then there is nothing to drop.

This is impossible.

You are checking to see if the session is null, which you used getActiveSession to retrieve. So if it is null, then there is nothing to drop.

6:53 am

cRush

Once again, do the dynamic_cast on the top, and delete this line.

Once again, do the dynamic_cast on the top, and delete this line.

6:51 am

cRush

remove this. also you dont need to place this into another managedreference - its already in a managedreference in this scope.

remove this. also you dont need to place this into another managedreference - its already in a managedreference in this scope.

6:51 am

cRush

dynamic cast here, instead.

dynamic cast here, instead.

6:48 am

cRush

const String&

const String&

6:47 am

cRush

Can we automate this by looping the PlanetMapCategory vector?

Can we automate this by looping the PlanetMapCategory vector?

6:45 am

cRush

[updated] Find Command to Session
[updated] Find Command to Session
Friday 29 Apr 2011
7:31 am

cRush

I agree. gmlr->addMapLocation(object) makes more sense here.

I agree. gmlr->addMapLocation(object) makes more sense here.

7:31 am

cRush

PlanetMapCategory and index are somewhat synonymous in this case - each PlanetMapCategory has a single index assigned to it. I don't think a hasIndex is proper in this case. However, I do feel tha...

PlanetMapCategory and index are somewhat synonymous in this case - each PlanetMapCategory has a single index assigned to it. I don't think a hasIndex is proper in this case.

However, I do feel that 17 should be replaced with the string representation of index 17, and compared to the name of the category.

2:53 am

oru

Encapsulate this better as well. Not sure if it is worth to create a single class to hold all these information but surely don't pass an objectID and 2 coordinates here. Pass the object, and in add...

Encapsulate this better as well. Not sure if it is worth to create a single class to hold all these information but surely don't pass an objectID and 2 coordinates here. Pass the object, and in addMapLocation(), get the data out you need there.

2:50 am

oru

I suggest using proper encapsulation here, add the following method: PlanetMapCategory::hasindex(int index) I would like to point out how important it is to use proper encapsulation. It not only m...

I suggest using proper encapsulation here, add the following method: PlanetMapCategory::hasindex(int index)

I would like to point out how important it is to use proper encapsulation. It not only makes the code lot cleaner but ways more flexible as well. While this particular change seems pretty minor, it adds a lot in the long run.

2:45 am

oru

[updated] PlanetMapCategories from client files.
[updated] PlanetMapCategories from client files.
Wednesday 06 Apr 2011
7:29 am

TheAnswer

>=

>=

7:29 am

TheAnswer

this is missing lockers. Should inherit the Manager from Mutex and add a Locker locker(this); call in the methods that modify the data

this is missing lockers.
Should inherit the Manager from Mutex and add a Locker locker(this); call in the methods that modify the data

7:28 am

TheAnswer

null check

null check

7:27 am

TheAnswer

null check

null check

7:26 am

TheAnswer

dangling pointer vendor

dangling pointer vendor

7:25 am

TheAnswer

When VendorCreature is deleted from ram vendor reference is left in the vendor manager and it becomes a dangling pointer corrupting ram

When VendorCreature is deleted from ram vendor reference is left in the vendor manager and it becomes a dangling pointer corrupting ram

7:22 am

TheAnswer

ManagedReference here is unneeded you already hold the reference in the previous declaration

ManagedReference here is unneeded you already hold the reference in the previous declaration

7:20 am

TheAnswer

missing locker

missing locker